Skip to content

feat(avm): mutations for accumulated data #19347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
IlyasRidhuan merged 2 commits into from
Jan 9, 2026
Merged

feat(avm): mutations for accumulated data #19347

IlyasRidhuan merged 2 commits into from
Jan 9, 2026
+254 −59

Conversation

@IlyasRidhuan
Copy link
Contributor

@IlyasRidhuan IlyasRidhuan commented Jan 6, 2026 •
edited
Loading

Adds revertible and non-revertible accumulated data mutations to the fuzzer

@IlyasRidhuan IlyasRidhuan mentioned this pull request Jan 6, 2026
Merged
@IlyasRidhuan Graphite App
Copy link
Contributor Author

IlyasRidhuan commented Jan 6, 2026 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Jan 6, 2026
Merged
Merged
@IlyasRidhuan IlyasRidhuan force-pushed the ir/01-04-feat_avm_mutations_for_accumulated_data branch from e8578e9 to ae09b1d Compare January 7, 2026 10:35
@IlyasRidhuan IlyasRidhuan mentioned this pull request Jan 7, 2026
Open
@IlyasRidhuan IlyasRidhuan force-pushed the ir/01-04-feat_avm_mutations_for_accumulated_data branch from ae09b1d to 3c26110 Compare January 7, 2026 10:43
@IlyasRidhuan IlyasRidhuan force-pushed the ir/01-04-feat_avm_defensively_assert_cd_hashes branch 2 times, most recently from 36ee031 to 86093ec Compare January 7, 2026 10:56
@IlyasRidhuan IlyasRidhuan force-pushed the ir/01-04-feat_avm_mutations_for_accumulated_data branch from 3c26110 to d291430 Compare January 7, 2026 10:56
@IlyasRidhuan IlyasRidhuan changed the base branch from ir/01-04-feat_avm_defensively_assert_cd_hashes to graphite-base/19347 January 7, 2026 15:33
@IlyasRidhuan IlyasRidhuan force-pushed the ir/01-04-feat_avm_mutations_for_accumulated_data branch from d291430 to c282ab6 Compare January 7, 2026 15:49
@IlyasRidhuan IlyasRidhuan force-pushed the graphite-base/19347 branch 2 times, most recently from 0ffaa16 to 1b5498a Compare January 8, 2026 12:48
@IlyasRidhuan IlyasRidhuan force-pushed the ir/01-04-feat_avm_mutations_for_accumulated_data branch from c282ab6 to 40f1713 Compare January 8, 2026 12:48
@IlyasRidhuan IlyasRidhuan changed the base branch from graphite-base/19347 to ir/01-08-fix_avm_capping_rd_size_and_fixing_pipes January 8, 2026 12:48
@IlyasRidhuan IlyasRidhuan mentioned this pull request Jan 8, 2026
Merged
@IlyasRidhuan IlyasRidhuan force-pushed the ir/01-04-feat_avm_mutations_for_accumulated_data branch from 40f1713 to fd2d950 Compare January 8, 2026 13:04
@IlyasRidhuan IlyasRidhuan changed the base branch from ir/01-08-fix_avm_capping_rd_size_and_fixing_pipes to graphite-base/19347 January 8, 2026 13:11
@IlyasRidhuan IlyasRidhuan force-pushed the ir/01-04-feat_avm_mutations_for_accumulated_data branch from fd2d950 to 5420487 Compare January 8, 2026 13:11
@IlyasRidhuan IlyasRidhuan changed the base branch from graphite-base/19347 to ir/01-08-fix_avm_capping_rd_size_and_fixing_pipes January 8, 2026 13:11
@IlyasRidhuan IlyasRidhuan marked this pull request as ready for review January 8, 2026 13:12
sirasistant
sirasistant reviewed Jan 8, 2026
View reviewed changes
Copy link
Contributor

@sirasistant sirasistant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general but we might need to ensure that the vectors are not larger than allowed by the protocol

sirasistant
sirasistant approved these changes Jan 8, 2026
View reviewed changes
Copy link
Contributor

@sirasistant sirasistant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@IlyasRidhuan IlyasRidhuan force-pushed the ir/01-04-feat_avm_mutations_for_accumulated_data branch from 667636d to 7e7dc6e Compare January 8, 2026 15:49
@IlyasRidhuan IlyasRidhuan force-pushed the ir/01-08-fix_avm_capping_rd_size_and_fixing_pipes branch from f92dbc1 to bdc0f68 Compare January 8, 2026 15:49
@IlyasRidhuan IlyasRidhuan changed the base branch from ir/01-08-fix_avm_capping_rd_size_and_fixing_pipes to graphite-base/19347 January 9, 2026 12:43
@IlyasRidhuan IlyasRidhuan force-pushed the ir/01-04-feat_avm_mutations_for_accumulated_data branch from 7e7dc6e to feb1780 Compare January 9, 2026 13:03
@IlyasRidhuan IlyasRidhuan changed the base branch from graphite-base/19347 to ir/01-08-fix_avm_capping_rd_size_and_fixing_pipes January 9, 2026 13:03
Base automatically changed from ir/01-08-fix_avm_capping_rd_size_and_fixing_pipes to merge-train/avm January 9, 2026 13:37
@IlyasRidhuan IlyasRidhuan force-pushed the ir/01-04-feat_avm_mutations_for_accumulated_data branch from feb1780 to 445b83c Compare January 9, 2026 13:38
@IlyasRidhuan IlyasRidhuan merged commit e2cf134 into merge-train/avm Jan 9, 2026
9 checks passed
@IlyasRidhuan IlyasRidhuan deleted the ir/01-04-feat_avm_mutations_for_accumulated_data branch January 9, 2026 13:39
@AztecBot AztecBot mentioned this pull request Jan 9, 2026
Merged
github-merge-queue bot pushed a commit that referenced this pull request Jan 9, 2026
@AztecBot
feat: merge-train/avm (#19454)
073eb9a 
BEGIN_COMMIT_OVERRIDE
feat(avm): Migrate contract db proxy to fuzzer context (#19421)
fix(avm): capping rd size and fixing pipes (#19420)
feat(avm): mutations for accumulated data (#19347)
chore!: remove dead columns and code from avm cpp (#19442)
END_COMMIT_OVERRIDE
This was referenced Jan 12, 2026
Open
Draft
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sirasistant sirasistant sirasistant approved these changes

@fcarreiro fcarreiro Awaiting requested review from fcarreiro

@dbanks12 dbanks12 Awaiting requested review from dbanks12

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@IlyasRidhuan @sirasistant